bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] make acl support optional


From: Mike Frysinger
Subject: Re: [patch] make acl support optional
Date: Tue, 8 Jan 2008 10:56:40 -0500
User-agent: KMail/1.9.7

On Tuesday 08 January 2008, Jim Meyering wrote:
> Mike Frysinger <address@hidden> wrote:
> > 2008-01-08  Mike Frysinger  <address@hidden>
> >
> >     * m4/acl.m4 (gl_FUNC_ACL): Wrap all ACL logic in a call to
> >     AC_ARG_ENABLE(acl).
> >
> > diff --git a/m4/acl.m4 b/m4/acl.m4
> > index 6a1951d..2e3a0c5 100644
> > --- a/m4/acl.m4
> > +++ b/m4/acl.m4
> > @@ -12,42 +12,53 @@ AC_DEFUN([gl_FUNC_ACL],
> >    AC_LIBOBJ([acl])
> >    AC_LIBOBJ([file-has-acl])
> >
> > -  dnl Prerequisites of lib/acl.c.
> > +  AC_ARG_ENABLE(acl,
> > +    AC_HELP_STRING([--disable-acl], [do not support ACLs]),
> > +    , [enable_acl=auto])
> > +
>
> ...
>
> > +  if test "x$use_acl" != "xno"; then
> > +    dnl Prerequisites of lib/acl.c.
> > +    use_acl=0
>
> Thanks.
> The above test of $use_acl should be $enable_acl.
> I've also hoisted the use_acl=0 definition and eliminated
> your 1-line "else" block.

ah of course ... i had the original AC_ARG_ENABLE() changing use_acl, but then 
i switched to enable_acl as i thought it looked less confusing, but i guess i 
missed a spot.

thanks!
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]