Re: please keep 'memmem' module simple

[Simon Josefsson]

Paul Eggert <address@hidden> writes:

> Simon Josefsson <address@hidden> writes:
>
>> Thus, I think it is appropriate to rename the current efficient 'memmem'
>> gnulib module to 'memmem-fast' and revert to the glibc implementation in
>> the gnulib 'memmem' module.
>
> A minor point: Was the intent to propagate this into the glibc
> version?

I don't know.  The old memmem in gnulib was a direct copy of the glibc
version.  Also, my experience with glibc is that even if the intent is
to propagate something back to glibc, that actually happening may be
held up indefinitely.  I think the deciding factor should be whether
glibc adopts the optimized memmem or not, rather than whether the
_intent_ is that glibc adopts it.

> If so, perhaps better names are "memmem" for the fast version and and
> "memmem-simple" for the simple one.

That would also work for me.

/Simon