bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

sha1/md[45]: a further refinement


From: Jim Meyering
Subject: sha1/md[45]: a further refinement
Date: Thu, 31 Jan 2008 13:07:05 +0100

Here's another refinement.
Simon, since you're listed as md4 owner, I'll wait for your ok...

>From 583a8ea5a0e5b56f46a5b423ca736b83ea2a0742 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Thu, 31 Jan 2008 13:04:07 +0100
Subject: [PATCH] Prefer "sizeof v" over the equivalent "4".

* lib/md4.c (set_uint32): Use "sizeof v" as memcpy length, not 4.
* lib/md5.c (set_uint32): Likewise.
* lib/sha1.c (set_uint32): Likewise.

Signed-off-by: Jim Meyering <address@hidden>
---
 lib/md4.c  |    2 +-
 lib/md5.c  |    2 +-
 lib/sha1.c |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/md4.c b/lib/md4.c
index daedaf5..dd1e2df 100644
--- a/lib/md4.c
+++ b/lib/md4.c
@@ -70,7 +70,7 @@ md4_init_ctx (struct md4_ctx *ctx)
 static void
 set_uint32 (char *cp, uint32_t v)
 {
-  memcpy (cp, &v, 4);
+  memcpy (cp, &v, sizeof v);
 }

 /* Put result from CTX in first 16 bytes following RESBUF.  The result
diff --git a/lib/md5.c b/lib/md5.c
index 50a2646..b6d307c 100644
--- a/lib/md5.c
+++ b/lib/md5.c
@@ -86,7 +86,7 @@ md5_init_ctx (struct md5_ctx *ctx)
 static void
 set_uint32 (char *cp, uint32_t v)
 {
-  memcpy (cp, &v, 4);
+  memcpy (cp, &v, sizeof v);
 }

 /* Put result from CTX in first 16 bytes following RESBUF.  The result
diff --git a/lib/sha1.c b/lib/sha1.c
index 22172a9..8869d43 100644
--- a/lib/sha1.c
+++ b/lib/sha1.c
@@ -73,7 +73,7 @@ sha1_init_ctx (struct sha1_ctx *ctx)
 static void
 set_uint32 (char *cp, uint32_t v)
 {
-  memcpy (cp, &v, 4);
+  memcpy (cp, &v, sizeof v);
 }

 /* Put result from CTX in first 20 bytes following RESBUF.  The result
--
1.5.4.rc5.1.ge6bfe




reply via email to

[Prev in Thread] Current Thread [Next in Thread]