Re: [patch] diffseq module dependency

[Bruno Haible]

Hi,

Michael Biggs wrote:
> The diffseq module seems to require MIN and MAX to be defined, so add a
> dependency on the minmax module to diffseq:

This is not all that is needed: The file that includes diffseq.h also needs
a few other #include statements. I'm applying the patch below.

When the programmer then looks at the #includes of his source files, he will
see that for "minmax.h" he needs the 'minmax' module, and for <stdbool.h>
be needs the 'stdbool' module. This is part of the normal process of
determining the needed gnulib modules, and therefore IMO does not need to
be duplicated here.

Bruno


2008-02-03  Bruno Haible  <address@hidden>

        * lib/diffseq.h: Add comments about required #includes.
        Reported by Michael Biggs <address@hidden>.

*** lib/diffseq.h.orig  2008-02-03 21:05:00.000000000 +0100
--- lib/diffseq.h       2008-02-03 03:48:32.000000000 +0100
***************
*** 1,6 ****
  /* Analyze differences between two vectors.
  
!    Copyright (C) 1988-1989, 1992-1995, 2001-2004, 2006, 2007 Free
     Software Foundation, Inc.
  
     This program is free software: you can redistribute it and/or modify
--- 1,6 ----
  /* Analyze differences between two vectors.
  
!    Copyright (C) 1988-1989, 1992-1995, 2001-2004, 2006-2008 Free
     Software Foundation, Inc.
  
     This program is free software: you can redistribute it and/or modify
***************
*** 50,56 ****
       NOTE_DELETE(ctxt, xoff) Record the removal of the object xvec[xoff].
       NOTE_INSERT(ctxt, yoff) Record the insertion of the object yvec[yoff].
       USE_HEURISTIC           (Optional) Define if you want to support the
!                              heuristic for large vectors.  */
  
  /* Maximum value of type OFFSET.  */
  #define OFFSET_MAX \
--- 50,61 ----
       NOTE_DELETE(ctxt, xoff) Record the removal of the object xvec[xoff].
       NOTE_INSERT(ctxt, yoff) Record the insertion of the object yvec[yoff].
       USE_HEURISTIC           (Optional) Define if you want to support the
!                              heuristic for large vectors.
!    Before including this file, you also need to include:
!      #include <limits.h>
!      #include <stdbool.h>
!      #include "minmax.h"
!  */
  
  /* Maximum value of type OFFSET.  */
  #define OFFSET_MAX \