bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Generalize GNUmakefile, ...


From: Simon Josefsson
Subject: Re: [PATCH] Generalize GNUmakefile, ...
Date: Thu, 20 Mar 2008 14:28:04 +0100
User-agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.1 (gnu/linux)

Eric Blake <address@hidden> writes:

> According to Simon Josefsson on 3/20/2008 4:23 AM:
> |> Hmm.  I was about to try to add the latest coreutils/autoconf/m4
> |> GNUmakefile to gnulib, to make it easier to share.  But gnulib already
> |> provides build-aux/GNUmakefile as part of the maintainer-makefile module,
> |> added by Simon a while ago (and originally borrowed from coreutils).
> |
> | Hi!  Thanks for looking into this, and sorry for slow response.  Merging
> | them would be useful.  There are some things in coreutils that I'd like
> | to have, but haven't had time to merge into gnulib.
>
> Here's stage 1 for the gnulib side - picking up useful tricks from
> coreutils into gnulib's copy.  I'd still like to consider splitting the
> module, and implementing gnulib-tool hooks to recognize top/GNUmakefile in
> a module description as a request to install the file in '.', regardless
> of whether build-aux is '.' or a subdirectory.
>
> I went ahead and applied this.

Looks fine, I'll test it in my projects.

The top/* hook seems like a good idea to me.

> | I don't care strongly about this.  The name 'maint-cfg.mk' haven't been
> | the best though, since it clashes with name completion of main.mk.  Is
> | cfg.mk too generic?  I think this would be a good opportunity to change
> | the name.
>
> Did you mean maint.mk, not main.mk?  But I'm okay with the name cfg.mk.

Right, maint.mk.  I see that you used cfg.mk, so I'm happy.

Thanks,
Simon




reply via email to

[Prev in Thread] Current Thread [Next in Thread]