Re: [PATCH] Describe which environment variables really control the interpretation of the response to -ok.

[Jim Meyering]

Bruno Haible <address@hidden> wrote:
> Here is a proposed compromise that enables the strict POSIX behaviour when
> POSIXLY_CORRECT is set. This is a POSIX compliance fix for the programs
> 'cp', 'mv', 'rm', 'find', 'xargs'.
>
> This is a continuation of the approach presented last year in
>   http://lists.gnu.org/archive/html/bug-gnulib/2007-08/msg00075.html
> Paul replied with the argument of POSIX compliance here:
>   http://lists.gnu.org/archive/html/bug-gnulib/2007-08/msg00093.html
> I think testing POSIXLY_CORRECT should address this argument.
>
> Tested with the 'yesno' module. (Why does the 'rpmatch' module not have a
> unit test? Why does it not even have an include file that declares the
> rpmatch function?)

Because no one has volunteered to write those.
We all know that there are many more modules without unit tests.
Back in the very early days when I moved 90% of the files from
coreutils' lib/ and m4/ into gnulib, there were no separate unit
tests at all, so you can blame me for a lot of it ;-)
I'm glad things are progressing on that front.

> Jim, Eric, is this ok to apply?
>
> 2007-08-18  Bruno Haible  <address@hidden>
>
>       * lib/rpmatch.c: Include stdbool.h, string.h, langinfo.h.
>       (N_): New macro.
>       (localized_pattern): New function/macro.
>       (try): Remove match, nomatch arguments. Copy the pattern into safe
>       memory before caching it.
>       (rpmatch): Use localized_pattern. Add translator comments.
>       * m4/rpmatch.m4 (gl_PREREQ_RPMATCH): Test for nl_langinfo and YESEXPR.
>       Suggested by Eric Blake.
>       * modules/rpmatch (Depends-on): Add stdbool.

Looks good to me.
Thanks for working on it.