Re: [Bug-tar] [GNU tar 1.20] testsuite: 2 7 8 13 14 16 17 22 28 29 44 45 46 48 51 52 61 63 64 65 67 68 69 70 71 72 73 74 failed

[H.Merijn Brand]

On Mon, 02 Jun 2008 06:01:59 -0600, Eric Blake <address@hidden> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> According to H.Merijn Brand on 5/21/2008 6:53 AM:
> |> | So obviously fseeko () (and.or fseek ()) are severely borked when
> |> | called as first call after fopen (), even if seek_offset == 0.
> |>
> |> Are you using the gnulib replacement for fseek/fseeko, or the native one?
> |
> | Native
> 
> Are you sure?  Please look at config.log and at the generated lib/stdio.h
> to see whether #define fseeko rpl_fseeko might be active.

3gl/GNU/tar-1.20 109 > grep -i gnulib config.log | grep -i seek
GNULIB_FSEEK='0'
GNULIB_FSEEKO='1'
GNULIB_LSEEK='1'
--8<--- lib/stdio.h
#if 1
# if 0
/* Provide fseek, fseeko functions that are aware of a preceding
   fflush(), and which detect pipes.  */
#  define fseeko rpl_fseeko
extern int fseeko (FILE *fp, off_t offset, int whence);
#  define fseek(fp, offset, whence) fseeko (fp, (off_t)(offset), whence)
# endif
#elif defined GNULIB_POSIXCHECK
# undef fseeko
# define fseeko(f,o,w) \
   (GL_LINK_WARNING ("fseeko is unportable - " \
                     "use gnulib module fseeko for portability"), \
    fseeko (f, o, w))
#endif
-->8---

It's inside # if 0, so I would think it's not active

> |> | --8<---
> |> |   if (seek_offset && fseek (fp, (long)seek_offset, 0))
> |> |     error (EXIT_FAILURE, errno, "%s", _("cannot seek"));
> |> | -->8---
> |>
> |> This shouldn't be necessary with a compliant fseek (or working gnulib
> |> fseek replacement).
> |
> | Indeed it shouldn't be needed, but it prevents hitting the bug on HP-UX
> | 10.20, a bug that won't be fixed. The chances that anyone will port GNU
> | libc to HP-UX 10.20 *AND* make the systems that could want it install
> | it are close to 0.
> 
> You've missed something fundamental here.  I am not asking to port glibc
> to HP-UX (nor do I think it is possible); rather, I am asking about
> gnulib, which is a different project.  gnulib is the owner of the various
> replacement stdio modules which are supposed to take up the slack when the
> native version is deficient.  My concern is that our attempts to work
> around your particular HP-UX bug need more help.

Just call. I'll do whatever I can. As long as I don't have to do it on AIX.

-- 
H.Merijn Brand         Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using & porting perl 5.6.2, 5.8.x, 5.10.x  on HP-UX 10.20, 11.00, 11.11,
& 11.23, SuSE 10.1 & 10.2, AIX 5.2, and Cygwin.       http://qa.perl.org
http://mirrors.develooper.com/hpux/            http://www.test-smoke.org
                        http://www.goldmark.org/jeff/stupid-disclaimers/