bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: acl: refactor error messages in copy-acl.c


From: Bruno Haible
Subject: Re: acl: refactor error messages in copy-acl.c
Date: Tue, 3 Jun 2008 00:07:25 +0200
User-agent: KMail/1.5.4

Jim Meyering wrote:
> >     * lib/copy-acl.c (qcopy_acl): New function, extracted from copy_acl.
> >     (copy_acl): Just a wrapper around qcopy_acl that emits the error
> >     messages.
> 
> Obviously an improvement, and looks correct.
> Go ahead.  Thanks!

Applied, together with a corresponding comment refinement:

        * lib/set-mode-acl.c (qset_acl): Document return value precisely.

--- lib/set-mode-acl.c.orig     2008-06-03 00:04:45.000000000 +0200
+++ lib/set-mode-acl.c  2008-06-03 00:04:16.000000000 +0200
@@ -42,8 +42,8 @@
    filename based operations on NAME.  If access control lists are not
    available, fchmod the target file to MODE.  Also sets the
    non-permission bits of the destination file (S_ISUID, S_ISGID, S_ISVTX)
-   to those from MODE if any are set.  System call return value
-   semantics.  */
+   to those from MODE if any are set.
+   Return 0 if successful.  Return -1 and set errno upon failure.  */
 
 int
 qset_acl (char const *name, int desc, mode_t mode)





reply via email to

[Prev in Thread] Current Thread [Next in Thread]