Re: GNUMakefile: don't fail if there is no .tarball-version

[Bruno Haible]

Eric Blake wrote:
>   In fact, it might be worth a patch to gnulib-tool, rather than to
> GNUmakefile, to guarantee that --create-testdir creates .tarball-version
> to simulate the 'make dist' process of any package which uses the
> GNUmakefile module.

I disagree: gnulib-tool should not do special actions to please particular
modules. (The 'alloca' module is a special exception, because it's specially
handled in automake.)

The 'gnumakefile' in particular does not provide functionality to the user
of the package, only to the maintainer. It does not change the way "make" and
"make check" work. It has no test suite. Therefore it doesn't make much sense
to include it in --create-testdir.

I'm applying this.

2008-06-04  Bruno Haible  <address@hidden>

        * gnulib-tool (func_create_testdir, func_create_megatestdir): Don't
        include the 'gnumakefile' module by default.
        Reported by Simon Josefsson.

--- gnulib-tool.orig    2008-06-04 12:40:04.000000000 +0200
+++ gnulib-tool 2008-06-04 12:28:57.000000000 +0200
@@ -3418,8 +3418,9 @@
     # Except config-h, which breaks all modules which use HAVE_CONFIG_H.
     # Except fnmatch-posix, which conflicts with fnmatch-gnu. FIXME.
     # Except ftruncate, mountlist, which abort the configuration on mingw. 
FIXME.
+    # Except gnumakefile, which breaks when there is no file 
'.tarball-version'.
     modules=`func_all_modules`
-    modules=`for m in $modules; do case $m in config-h | fnmatch-posix | 
ftruncate | mountlist) ;; *) echo $m;; esac; done`
+    modules=`for m in $modules; do case $m in config-h | fnmatch-posix | 
ftruncate | mountlist | gnumakefile) ;; *) echo $m;; esac; done`
   fi
   modules=`for m in $modules; do echo $m; done | LC_ALL=C sort -u`
 
@@ -3894,7 +3895,8 @@
   # Then, all modules all together.
   # Except config-h, which breaks all modules which use HAVE_CONFIG_H.
   # Except fnmatch-posix, which conflicts with fnmatch-gnu. FIXME.
-  allmodules=`for m in $allmodules; do if test $m != config-h && test $m != 
fnmatch-posix; then echo $m; fi; done`
+  # Except gnumakefile, which breaks when there is no file '.tarball-version'.
+  allmodules=`for m in $allmodules; do if test $m != config-h && test $m != 
fnmatch-posix && test $m != gnumakefile; then echo $m; fi; done`
   func_create_testdir "$megatestdir/ALL" "$allmodules"
   func_append megasubdirs "ALL"