bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gnulib-cache.m4 readability


From: Bruno Haible
Subject: Re: gnulib-cache.m4 readability
Date: Mon, 23 Jun 2008 23:16:55 +0200
User-agent: KMail/1.5.4

Eric Blake wrote:
> The task of tracking changes to gnulib-cache.m4 would be a lot easier if 
> modules were listed on a separate line, as in the proposed patch; then there 
> is 
> no longer any line-wrapping of the gl_MODULES portion of the file, and the 
> added or deleted modules diff independently of the remaining modules.

Fine with me.

> I did 
> this only for gl_MODULES; the comment on a command-line invocation to 
> reproduce 
> the import needs to remain as a run-on line to be pastable into a shell.

Yes, right.

> OK to commit?

Since you are already pointing out that your sed program is likely unportable,
why not use the classical style with s and t commands instead? It's not much
longer:

/gl_MODULES(/ {
  :a
    s/)/)/
    tb
    N
    ba
  :b
  s,^.*gl_MODULES([[ ]*\([^])]*\).*$,cached_specified_modules="\1",p
}


Bruno





reply via email to

[Prev in Thread] Current Thread [Next in Thread]