bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH]: Fix for several getdate.y issues (amended patch #3)


From: Ondřej Vašík
Subject: Re: [PATCH]: Fix for several getdate.y issues (amended patch #3)
Date: Fri, 04 Jul 2008 18:04:37 +0200

Hello,
as discussed with Jim Meyering via IRC, I'm sending changed version of
the patch #3 to the list. This one patch adds range to valid TZ and
handles correctly hours when no minutes are specified (until that patch
is UTC+14 handled incorrectly as UTC+0:14) and are in common range of
UTC-12 to UTC+14. 
Although there are few different implementations of TZ limits (Microsoft
uses range UTC-14 to UTC+14 , various sources show that only TZ between
UTC-12 and UTC+14 are in use), this patch uses range UTC-24 to UTC+24 as
recommended for TZ environmental variable in POSIX
(http://www.opengroup.org/onlinepubs/000095399/basedefs/xbd_chap08.html).
After applying that patch invalid TZ will show an invalid date format
error (because of double increment of pc->zones_seen).
I added few tests to gnulib getdate test suite to check if various TZ
formats are showing the same result.

Greetings,
         Ondrej Vasik

Attachment: getdate_3_TZinvalidchecks.patch
Description: Text Data

Attachment: signature.asc
Description: Toto je digitálně podepsaná část zprávy


reply via email to

[Prev in Thread] Current Thread [Next in Thread]