Re: diversion failure [was: snapshot in preparation for m4 1.4.12]

[Bruno Haible]

Eric Blake wrote:
> In looking at this further, it looks like line 4179 of vasnprintf.c should
> _not_ count precision as a prefix if prec_ourselves is nonzero.

Yes. Now that you say it, it's obvious that the code in line 4179 should be
in sync with the code in line 4077.

> Without the patch to vasnprintf.c, the added test in test-vasnprintf-posix
> dumped core when I used
> 
> $ gl_cv_func_printf_sizes_c99=no gl_cv_func_printf_infinite=no
> gl_cv_func_printf_directive_a=no gl_cv_func_printf_directive_f=no
> gl_cv_func_printf_flag_zero=no gl_cv_func_printf_precision=no
> ./gnulib-tool --with-tests --test vasnprintf-posix
> 
> on cygwin.  I traced this to an attempt to call snprintf(buf, 12, "%d%n",
> 4000, 1234567, &count).
> 
> OK to apply?  Are there other files in lib or tests that need matching
> modifications?

Yes, please apply. 4 test files should be modified in sync:

$ grep -rl 4000d tests/
tests/test-snprintf-posix.h
tests/test-sprintf-posix.h
tests/test-vasnprintf-posix.c
tests/test-vasprintf-posix.c

Thanks!!

Bruno