bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH]: glthread cond win32 compilation problem


From: Paolo Bonzini
Subject: Re: [PATCH]: glthread cond win32 compilation problem
Date: Fri, 12 Sep 2008 09:44:08 +0200
User-agent: Thunderbird 2.0.0.16 (Macintosh/20080707)

> 2008-09-11  Yoann Vandoorselaere  <address@hidden>
>             Bruno Haible  <address@hidden>
> 
>       * lib/glthread/cond.h (ETIMEDOUT): Define to a fallback value if not
>       defined by <errno.h>.
> 
> + /* Possible return value of glthread_cond_timedwait.
> +    Use a random value as fallback replacement.  */
> + # ifndef ETIMEDOUT
> + #  define ETIMEDOUT 1789
> + # endif

I propose instead 60, or better (WSAETIMEDOUT - 10000).  So it would be,

# ifndef ETIMEDOUT
#  ifdef WSAETIMEDOUT
#   define ETIMEDOUT (WSAETIMEDOUT - 10000)
#  else
#   define ETIMEDOUT 1789
#  endif
# endif

The reason is that I have a pending patch to provide winsock wrappers
that are more compatible with POSIX, and I'm using this convention for
missing error codes, because for example WSAEBADF == EBADF + 10000 already.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]