Re: [PATCH]: glob win32 compatibility fixes

[Yoann Vandoorselaere]

Hi Bruno,

Le vendredi 12 septembre 2008 à 02:17 +0200, Bruno Haible a écrit :
> > Attached are a few patch that fixes glob ...
> > compilation problem under MinGW.
> 
> A couple of details in this patch can be improved:
> 
>   - The predefine 'WIN32' is sometimes also defined for Cygwin, and is
>     not defined on some native Win32 platforms. The right test for platforms
>     that use the MSVCRT is
>        (defined _WIN32 || defined __WIN32__) && ! defined __CYGWIN__
> 
>   - You comment out the use of <pwd.h> and provide no replacement.
>     Nowadays, Windows systems have a home directory per user, but
>     getenv("HOME") is usually not set. The standard way to get the
>     home directory is getenv("HOMEDRIVE") and getenv("HOMEPATH") and
>     glue the two strings together (by simple string concatenation).

Thanks for the quick review, updated path attached!

-- 
Yoann Vandoorselaere <address@hidden>

glob-win32.diff
Description: Text Data