Re: [RFT] Wrap winsock functions for improved compatibility

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Paolo Bonzini on 9/12/2008 6:53 AM:
>> - > It needs to be tested on Windows (mingw and cygwin)
>>
>>   The patch is supposed to change nothing on Cygwin, right? Cygwin has
>>   perfectly fine POSIX socket support already.
> 
> I added a #error to verify that.  That's why I needed testing on Cygwin.

Yes, cygwin has a working <sys/socket.h>.  Do you have a repository
somewhere that I can pull from to test on cygwin, before this hits the
master gnulib.git on savannah?  The attachment did not apply cleanly, and
I'm feeling too lazy this morning to try to fix it (it's Friday, after all):

$ git am -3 ../winsock.patch
Patch does not have a valid e-mail address.
$ git apply ../winsock.patch
../winsock.patch:20: trailing whitespace.
# ifdef __CYGWIN__
../winsock.patch:21: trailing whitespace.
#  error "Cygwin does have a sys/socket.h, doesn't it?!?"
../winsock.patch:22: trailing whitespace.
# endif
../winsock.patch:23: trailing whitespace.

../winsock.patch:43: trailing whitespace.
# if @HAVE_WINSOCK2_H@
fatal: git-apply: bad git-diff - expected /dev/null on line 159
$


For that matter, you could do:

$ git push address@hidden:/srv/git/gnulib/ericb.git +HEAD:mob

(I love repo.or.cz's concept of anonymous write access to a staging
repository)

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkjKaLYACgkQ84KuGfSFAYDMPACfRY8IbLVmGFjv/HGEFFFpCX95
WS8AnR19vct8pWyfbHxPIUeP8TS8UQqR
=k+T0
-----END PGP SIGNATURE-----