Re: [PATCH] enhance the bootstrap script to support gnulib as a submodule

[Ralf Wildenhues]

Hi Paolo,

a couple of comments:

* Paolo Bonzini wrote on Mon, Sep 29, 2008 at 11:45:39AM CEST:
> 
> in GNU sed I want to attach each commit with an exact version of gnulib,
> because otherwise the bootstrapping shell script (used to compile a
> decent sed without using configure) most likely won't work.

> This is a natural use case for git's submodule feature; the attached
> patch makes the bootstrap script use submodules to check out gnulib.

Is it still possible to save space by hardlinking gnulib's object
storage with that of other gnulib trees?

> --- a/build-aux/bootstrap
> +++ b/build-aux/bootstrap

> +    git submodule init || exit $@
> +    git submodule update || exit $@

Did you mean
  || exit $?

(three instances)?

Cheers,
Ralf

> +  # Redirect the gnulib submodule to the directory on the command line
> +  # if possible.
> +  if test -d $GNULIB_SRCDIR/.git && \

Please quote $GNULIB_SRCDIR.

> +     git_modules_config submodule.gnulib.url >/dev/null; then
> +    git submodule init
> +    git config --replace-all submodule.gnulib.url "`cd $GNULIB_SRCDIR && 
> pwd`"

Needs quoting here, too; resp. for portability the result of the pwd
should be put in a temporary variable.

Cheers,
Ralf