bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fts.m4: correct the test for statfs.f_type


From: Bruno Haible
Subject: Re: [PATCH] fts.m4: correct the test for statfs.f_type
Date: Tue, 30 Sep 2008 23:07:41 +0200
User-agent: KMail/1.5.4

Hi Jim,

> I noticed that the configure-time test for the f_type member
> of struct statfs was failing on some systems.
> 
> It didn't include <sys/statfs.h>.
> I've pushed the obvious fix:

This introduces a regression on HP-UX.

The use of HAVE_STRUCT_STATFS_F_TYPE is predicated by
HAVE_SYS_VFS_H && HAVE_FSTATFS. Without this predicate, the test would
fail to detect that 'struct statfs' has an f_type field on MacOS X, *BSD,
HP-UX, and OSF/1. With this predicate, the test fails to detect it on
HP-UX.

Here's the matrix:

             fstatfs()    <sys/statfs.h>   <sys/vfs.h>    f_type

glibc          *               *               *            *
MacOS X        *                                            *
FreeBSD        *                                            *
OpenBSD        *                                            *
NetBSD         *                                            *
AIX                            *               *            *
HP-UX          *                               *            *
IRIX           *               *               *
Solaris        *               *               *
OSF/1          *                                            *
Cygwin         *               *               *            *

'struct statfs' is defined
  - in <sys/statfs.h> on glibc, AIX, IRIX, Solaris.
  - in <sys/mount.h> on MacOS X, FreeBSD, OpenBSD, NetBSD, OSF/1.
  - in <sys/vfs.h> on Cygwin, HP-UX.

Bruno





reply via email to

[Prev in Thread] Current Thread [Next in Thread]