Re: [PATCH] Implementation of fsync for Windows

[Richard W.M. Jones]

On Wed, Oct 01, 2008 at 05:51:23PM +0000, Eric Blake wrote:
> Richard W.M. Jones <rjones <at> redhat.com> writes:
> 
> > 
> > Like the earlier patch, but this relicenses to LGPLv2+, includes
> > license text, and assigns everything to the FSF.
> 
> Do you have copyright on file for gnulib yet?

No, but the general Red Hat assignment should cover it.

At this time I have also applied to FSF for copyright assignment so
that process should go through in the next few weeks.

> > +#else /* Windows */
> 
> Technically, this is #else /* !Windows */

Yes ... originally this was #endif, and I changed it without changing
the comment :-(

> > +lib/fsync.c
> > +m4/fsync.m4
> > +
> > +Depends-on:
> > +unistd
> 
> Should this also depend on the errno module?

<errno.h> should only be used on Windows (or MinGW / cross-compiling).

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
Read my OCaml programming blog: http://camltastic.blogspot.com/
Fedora now supports 68 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora