Re: [PATCH] bootstrap: check for AC_PROG_LIBTOOL as well as AM_PROG_LIBTOOL

[Jim Meyering]

Ralf Wildenhues <address@hidden> wrote:

> * Jim Meyering wrote on Sun, Oct 05, 2008 at 07:42:45PM CEST:
>> Bruno Haible <address@hidden> wrote:
>> >
>> > \> is also not a portable piece of regular expression: not in a basic 
>> > regex,
>> > and not in an extended regex. It is a GNU extension.
>>
>> It works with Solaris 10's grep,
>> so maybe it works with some others, too.
>
> FWIW, it fails with several other vendor greps.
>
>> Or better still, just use awk.
>> Then we get alternation back, and can kludge around
>> the lack of a portable end-of-word abbreviation:
>
> In a way, this is all a kludge anyway, because you do not see macro
> invocations that are only visible through m4 expansion, from other
> macro files, etc.  Only m4 can parse m4.  But we all knew that, and
> still there is the bootstrapping issue ...
>
> IMVHO you could just grep without word endings.  That's good enough
> for this script.

Yes, that has the advantage of being slightly simpler, I think,
in spite of the two separate grep invocations.  I hope this is
the last iteration ;-)

>From 4aba8be325dc665dada4368aa26a4be4961fd2a7 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sun, 5 Oct 2008 19:47:18 +0200
Subject: [PATCH] bootstrap: check for LT_INIT more portably still ;-)

* build-aux/bootstrap: Don't rely on \>, since it's not portable.
Spotted by Bruno Haible.
---
 ChangeLog           |    4 ++++
 build-aux/bootstrap |    4 ++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index bbc3db5..4b1139e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
 2008-10-05  Jim Meyering  <address@hidden>

+       bootstrap: check for LT_INIT more portably still ;-)
+       * build-aux/bootstrap: Don't rely on \>, since it's not portable.
+       Spotted by Bruno Haible.
+
        bootstrap: check for LT_INIT more portably
        * build-aux/bootstrap: Avoid using grep -E, since it's not
        portable enough.  Suggestion from Bruno Haible.
diff --git a/build-aux/bootstrap b/build-aux/bootstrap
index 1ad154f..0d76686 100755
--- a/build-aux/bootstrap
+++ b/build-aux/bootstrap
@@ -601,9 +601,9 @@ do
     # We'd like to use grep -E, to see if any of LT_INIT,
     # AC_PROG_LIBTOOL, AM_PROG_LIBTOOL is used in configure.ac,
     # but that's not portable enough (e.g., for Solaris).
-    grep '^[    ]*A[CM]_PROG_LIBTOOL\>' configure.ac >/dev/null \
+    grep '^[    ]*A[CM]_PROG_LIBTOOL' configure.ac >/dev/null \
       && use_libtool=1
-    grep '^[    ]*LT_INIT\>' configure.ac >/dev/null \
+    grep '^[    ]*LT_INIT' configure.ac >/dev/null \
       && use_libtool=1
     test $use_libtool = 0 \
       && continue
--
1.6.0.2.307.gc427