Warnings to be fixed

[Reuben Thomas]

Compiling with the Debian gnulib snapshot of 20081001, I am delighted that I 
no longer get warnings about #include_next. (Un?)fortunately, this enables 
me more easily to spot "real" warnings:

gl_anylinked_list2.h: In function ‘gl_linked_node_value’:
gl_anylinked_list2.h:124: warning: unused parameter ‘list’
gl_anylinked_list2.h: In function ‘gl_linked_node_set_value’:
gl_anylinked_list2.h:130: warning: unused parameter ‘list’
gl_anylinked_list2.h: In function ‘gl_linked_iterator_free’:
gl_anylinked_list2.h:910: warning: unused parameter ‘iterator’
gl_anylinked_list2.h: In function ‘gl_linked_iterator’:
gl_anylinked_list2.h:818: warning: ‘result.j’ is used uninitialised in this 
function
gl_anylinked_list2.h:818: warning: ‘result.i’ is used uninitialised in this 
function
gl_anylinked_list2.h:818: warning: ‘result.count’ is used uninitialised in 
this function
gl_anylinked_list2.h: In function ‘gl_linked_iterator_from_to’:
gl_anylinked_list2.h:889: warning: ‘result.j’ is used uninitialised in this 
function
gl_anylinked_list2.h:889: warning: ‘result.i’ is used uninitialised in this 
function
gl_anylinked_list2.h:889: warning: ‘result.count’ is used uninitialised in 
this function
gl_array_list.c: In function ‘gl_array_iterator_free’:
gl_array_list.c:492: warning: unused parameter ‘iterator’
gl_array_list.c: In function ‘gl_array_iterator’:
gl_array_list.c:439: warning: ‘result.j’ is used uninitialised in this 
function
gl_array_list.c:439: warning: ‘result.i’ is used uninitialised in this 
function
gl_array_list.c: In function ‘gl_array_iterator_from_to’:
gl_array_list.c:460: warning: ‘result.j’ is used uninitialised in this 
function
gl_array_list.c:460: warning: ‘result.i’ is used uninitialised in this 
function
openat-die.c:31: warning: no previous prototype for ‘openat_save_fail’
openat-die.c:44: warning: no previous prototype for ‘openat_restore_fail’
open-safer.c: In function ‘open_safer’:
open-safer.c:43: warning: signed and unsigned type in conditional expression
printf-args.c: In function ‘printf_fetchargs’:
printf-args.c:93: warning: signed and unsigned type in conditional 
expression
vasnprintf.c: In function ‘vasnprintf’:
vasnprintf.c:4442: warning: comparison between signed and unsigned

which should presumably be fixed. There seem to be four main types here:

1. Unused parameter. (I'm assuming the parameter is there for a good 
reason.)

2. Use of uninitialised storage.

3. Functions declared non-static without previous prototype.

4. Mixed signed and unsigned use.

I'm quite happy to help fix these, and I'll do a better job if someone 
indicates how each sort of warning should be fixed in gnulib.

--
http://rrt.sc3d.org/ | canonize, v.  to sanctify a dead sinner (Bierce)