bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: unicodeio.c ignores fwrite return value


From: Bruno Haible
Subject: Re: unicodeio.c ignores fwrite return value
Date: Thu, 13 Nov 2008 01:59:26 +0100
User-agent: KMail/1.5.4

Paolo Bonzini wrote:
> ... it makes no sense at all (and gives a false sense of security) to
> add the attribute to fwrite if you do not add it to fflush and fclose too.

Additionally, it seems strange to use the same trigger (_FORTIFY_SOURCE = 2)
for two semantically very different things: for enabling runtime checks
against buffer overflows, and for enabling compile-time warnings for sloppy
programming which in the worst case yields a crash through NULL pointer
dereference. IMO the warnings would be better controlled by a gcc warning
option, not by a C macro.

Bruno





reply via email to

[Prev in Thread] Current Thread [Next in Thread]