Re: Bug in lib-link.m4 (gettext-0.17)

[Bruno Haible]

Hello,

Charles Wilson wrote in
<http://lists.gnu.org/archive/html/bug-gnu-utils/2008-12/msg00058.html>:
> The following snippet in lib-link.m4
> 
>   dnl Assume the include files are nearby.
>   additional_includedir=
>   case "$found_dir" in
>     */$acl_libdirstem | */$acl_libdirstem/)
>       basedir=`echo "X$found_dir" | sed -e 's,^X,,' -e
> "s,/$acl_libdirstem/"'*$,,'`
>       LIB[]NAME[]_PREFIX="$basedir"
>       additional_includedir="$basedir/include"
>     ;;
>   esac
> 
> which occurs around line 413 has the effect of resetting
> LIB[]NAME[]_PREFIX as each dependencies of NAME is found.

Thanks for reporting this. This patch should fix it. Committed in gnulib and
gettext.


2008-12-30  Bruno Haible  <address@hidden>

        * m4/lib-prefix.m4 (AC_LIB_LINKFLAGS_BODY): Don't overwrite
        LIB${NAME}_PREFIX when considering the dependencies of lib${name}.
        Reported by Charles Wilson <address@hidden>.

*** m4/lib-link.m4.orig 2008-12-31 00:23:30.000000000 +0100
--- m4/lib-link.m4      2008-12-31 00:22:27.000000000 +0100
***************
*** 1,4 ****
! # lib-link.m4 serial 16 (gettext-0.18)
  dnl Copyright (C) 2001-2008 Free Software Foundation, Inc.
  dnl This file is free software; the Free Software Foundation
  dnl gives unlimited permission to copy and/or distribute it,
--- 1,4 ----
! # lib-link.m4 serial 17 (gettext-0.18)
  dnl Copyright (C) 2001-2008 Free Software Foundation, Inc.
  dnl This file is free software; the Free Software Foundation
  dnl gives unlimited permission to copy and/or distribute it,
***************
*** 446,457 ****
              case "$found_dir" in
                */$acl_libdirstem | */$acl_libdirstem/)
                  basedir=`echo "X$found_dir" | sed -e 's,^X,,' -e 
"s,/$acl_libdirstem/"'*$,,'`
!                 LIB[]NAME[]_PREFIX="$basedir"
                  additional_includedir="$basedir/include"
                  ;;
                */$acl_libdirstem2 | */$acl_libdirstem2/)
                  basedir=`echo "X$found_dir" | sed -e 's,^X,,' -e 
"s,/$acl_libdirstem2/"'*$,,'`
!                 LIB[]NAME[]_PREFIX="$basedir"
                  additional_includedir="$basedir/include"
                  ;;
              esac
--- 446,461 ----
              case "$found_dir" in
                */$acl_libdirstem | */$acl_libdirstem/)
                  basedir=`echo "X$found_dir" | sed -e 's,^X,,' -e 
"s,/$acl_libdirstem/"'*$,,'`
!                 if test "$name" = '$1'; then
!                   LIB[]NAME[]_PREFIX="$basedir"
!                 fi
                  additional_includedir="$basedir/include"
                  ;;
                */$acl_libdirstem2 | */$acl_libdirstem2/)
                  basedir=`echo "X$found_dir" | sed -e 's,^X,,' -e 
"s,/$acl_libdirstem2/"'*$,,'`
!                 if test "$name" = '$1'; then
!                   LIB[]NAME[]_PREFIX="$basedir"
!                 fi
                  additional_includedir="$basedir/include"
                  ;;
              esac