Re: [PATCH] Add 'safe-alloc' module

[David Lutterkort]

Hi Bruno,

On Thu, 2009-02-19 at 23:59 +0100, Bruno Haible wrote:
> Thanks for proposing such a nice module!

All glory for this lies with Dan (and Jim Meyering for doing a
preliminary review)

> For a module as basic as this one, in gnulib, I think it's essential that the
> copyright is with the FSF. Can you arrange with Daniel Berrange and/or his
> employer (Red Hat) that the copyright gets assigned?

I was told that Red Hat has a blanket agreement with the FSF for
copyright assignment. Whatever I did for this module, I did during work
hours, so copyright belongs to Red Hat. I think that is also true for
Dan (cc'd him so he can confirm that explicitly)

Can somebody from the FSF confirm that ? I did adjust the copyright
notice in the source files.

> Otherwise, looks well done. I see only a couple of minor points to be
> resolved:
>   - avoid collision between xalloc.h and safe-alloc.h over xalloc_oversized,

Ok. I'll rename xalloc_oversized to safe_alloc_oversized

>   - use xalloc_oversized also before calling calloc, because most libc
>     implementations will not have the overflow check,

Ok.

>   - use GNU conventions (space between identifier and opening parenthesis,
>     placement of braces) in safe-alloc.h,

Oops .. 'indent --no-tabs' doesn't do macros, of course.

>   - perhaps a unit test?

Added a very basic one.

Attached is an incremental patch with those changes.

David

0002-Changes-suggested-by-Bruno-Haible.patch
Description: Text Data