bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] filevercmp: fix regular expression of file suffix


From: Bruno Haible
Subject: Re: [PATCH] filevercmp: fix regular expression of file suffix
Date: Fri, 27 Feb 2009 17:02:56 +0100
User-agent: KMail/1.9.9

Hello Kamil,

> as reported by Sven Joachim at 
> http://lists.gnu.org/archive/html/bug-coreutils/2009-02/msg00264.html
> current filevercmp implementation does not work well for hidden files. 
> Attached patch fixes the strange behavior.

As I understand it, the patch does not fix two things that were mentioned
negatively by Sven:
  - that hidden files appear at the end, rather than at the beginning,
  - that "a~" precedes "a".

Also, in the patch, the variable 'read_dot' is confusing. Should it not
be called 'read_nondot'?

Should I commit your patch nevertheless?

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]