bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gnulib-tool, maint.mk: use $MAKE not make


From: Bruno Haible
Subject: Re: gnulib-tool, maint.mk: use $MAKE not make
Date: Sat, 14 Mar 2009 16:51:46 +0100
User-agent: KMail/1.9.9

Hi Ralf,

>     * gnulib-tool: Default $MAKE to 'make'.
>     (func_create_testdir, func_create_megatestdir): Use $MAKE rather
>     than make.  Initialize $MAKE in the do-autobuild script.
>     * top/maint.mk (init-coverage, build-coverage): Use $(MAKE)
>     rather than make.

This is fine. But it should be committed in 3 separate commits, since it's 3
logically independent things:
  - gnulib-tool lines 4200..4270: this modifies the files that are generated
    by gnulib-tool. $MAKE can be set on the target machine.
  - the rest of the gnulib-tool patch: this changes the commands invoked
    by gnulib-tool.
  - top/maint.mk. Btw, why does this use $(MAKE) and not $(MAKE) $(MAKEFLAGS)?

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]