bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: string.h uses restrict


From: Jim Meyering
Subject: Re: string.h uses restrict
Date: Sat, 04 Apr 2009 10:27:17 +0200

Ralf Wildenhues wrote:
> Hello Reuben,
>
> a couple of nits:

Thanks, Ralf.
Those buglets were from coreutils' maint.mk.
Here's what I expect to push in your name:

>From d75bcea4cfc7927535d19d34d8d103621b4a0d6d Mon Sep 17 00:00:00 2001
From: Ralf Wildenhues <address@hidden>
Date: Sat, 4 Apr 2009 10:25:18 +0200
Subject: [PATCH] tests: make syntax-checks more robust

* maint.mk (_prohibit_regexp): Add ';' at end of ':'-introduced
comment so that the comment doesn't gobble up the following test
for a missing regexp definition.
(_header_without_use): Escape all '.'s in a header file name,
not just the first one.
---
 maint.mk |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/maint.mk b/maint.mk
index 554b90a..dd780ad 100644
--- a/maint.mk
+++ b/maint.mk
@@ -103,7 +103,7 @@ _ignore_case = $$(test -n "$$ignore_case" && echo -i || :)
 # If the offending construct can be matched with a grep-E-style regexp,
 # use this macro.  The shell variables "re" and "msg" must be defined.
 define _prohibit_regexp
-  dummy=; : so we do not need a semicolon before each use              \
+  dummy=; : so we do not need a semicolon before each use;             \
   test "x$$re" != x || { echo '$(ME): re not defined' 1>&2; exit 1; }; \
   test "x$$msg" != x || { echo '$(ME): msg not defined' 1>&2; exit 1; };\
   grep $(_ignore_case) -nE "$$re" $$($(VC_LIST_EXCEPT)) &&             \
@@ -225,7 +225,7 @@ sc_prohibit_HAVE_MBRTOWC:
 # h: the header, enclosed in <> or ""
 # re: a regular expression that matches IFF something provided by $h is used.
 define _header_without_use
-  h_esc=`echo "$$h"|sed 's/\./\\./'`;                                  \
+  h_esc=`echo "$$h"|sed 's/\./\\./g'`;                                 \
   if $(VC_LIST_EXCEPT) | grep '\.c$$' > /dev/null; then                        
\
     files=$$(grep -l '^# *include '"$$h_esc"                           \
             $$($(VC_LIST_EXCEPT) | grep '\.c$$')) &&                   \
--
1.6.2.rc1.285.gc5f54




reply via email to

[Prev in Thread] Current Thread [Next in Thread]