bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patch] faster fnmatch


From: Ralf Wildenhues
Subject: Re: [Patch] faster fnmatch
Date: Fri, 1 May 2009 11:17:36 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

Hello Ondrej,

* Ondrej Bilka wrote on Thu, Apr 30, 2009 at 10:41:49PM CEST:
> I here attach compiled fnmatch I wrote as gnulib module. 

I haven't read your patch closely, but it fails to check the return
value from all of the malloc/realloc... functions, opening up several
opportunities for segmentation violations.

Since this is a library module, fnmatch should instead fail gracefully
and report the failure to its caller.

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]