bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

glob: mingw failures


From: Simon Josefsson
Subject: glob: mingw failures
Date: Sat, 02 May 2009 09:02:35 +0200
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.92 (gnu/linux)

The glob module fails on mingw:

./gnulib-tool --dir m --create-testdir --with-tests glob
warning: module glob depends on a module with an incompatible license: mbsrtowcs
warning: module glob depends on a module with an incompatible license: strnlen1
...
cd m
./configure --host=i586-mingw32msvc --build=i686-pc-linux-gnu
make

i586-mingw32msvc-gcc -DHAVE_CONFIG_H -I. -I..     -g -O2 -MT glob.o -MD -MP -MF 
.deps/glob.Tpo -c -o glob.o glob.c
glob.c:154:21: error: fnmatch.h: No such file or directory

The reason is the fnmatch module doesn't create fnmatch.h.  It needs
fnmatch-posix or fnmatch-gnu for that.  According to modules/glob:

  glob() function: Search for files and directories with paths matching a
  pattern, with GNU extensions.

This suggests that glob should depend on fnmatch-gnu.  But it also
suggests the glob-module should be renamed to glob-gnu, following our
usual naming pattern?

Finally, Bruno, the license on strnlen1 and mbsrtowcs needs to say
LGPLv2+ instead of just LGPL (implicitly LGPLv3+) if glob-gnu uses it.
Are you OK with the patch below, effectively re-licensing the code?

/Simon

diff --git a/ChangeLog b/ChangeLog
index 1b3895f..74b8abb 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2009-05-02  Simon Josefsson  <address@hidden>
+
+       * NEWS: Describe change.
+       * MODULES.html.sh: Rename glob to glob-gnu.
+       * modules/glob: Rename to modules/glob-gnu.
+       * modules/mbsrtowcs (License): Change license to LGPLv2+.
+       * modules/strnlen1 (License): Likewise.
+
 2009-05-01  Ralf Wildenhues  <address@hidden>
             Bruno Haible  <address@hidden>
 
diff --git a/MODULES.html.sh b/MODULES.html.sh
index 06afa2d..d6bbdd7 100755
--- a/MODULES.html.sh
+++ b/MODULES.html.sh
@@ -2388,7 +2388,7 @@ func_all_modules ()
   func_module fnmatch
   func_module fnmatch-posix
   func_module fnmatch-gnu
-  func_module glob
+  func_module glob-gnu
   func_module exclude
   func_end_table
 
diff --git a/NEWS b/NEWS
index 005fa7e..d8e49fc 100644
--- a/NEWS
+++ b/NEWS
@@ -6,6 +6,8 @@ User visible incompatible changes
 
 Date        Modules         Changes
 
+2009-05-02  glob            Renamed to glob-gnu.
+
 2009-04-26  modules/uniconv/u8-conv-from-enc
             modules/uniconv/u16-conv-from-enc
             modules/uniconv/u32-conv-from-enc
diff --git a/modules/glob-gnu b/modules/glob-gnu
index b765be7..64957d4 100644
--- a/modules/glob-gnu
+++ b/modules/glob-gnu
@@ -13,7 +13,7 @@ alloca
 d-type
 dirfd
 extensions
-fnmatch
+fnmatch-gnu
 getlogin_r
 memchr
 mempcpy
diff --git a/modules/mbsrtowcs b/modules/mbsrtowcs
index ad30746..f8a0069 100644
--- a/modules/mbsrtowcs
+++ b/modules/mbsrtowcs
@@ -27,8 +27,7 @@ Include:
 <wchar.h>
 
 License:
-LGPL
+LGPLv2+
 
 Maintainer:
 Bruno Haible
-
diff --git a/modules/strnlen1 b/modules/strnlen1
index d6874ee..a945c73 100644
--- a/modules/strnlen1
+++ b/modules/strnlen1
@@ -17,7 +17,7 @@ Include:
 "strnlen1.h"
 
 License:
-LGPL
+LGPLv2+
 
 Maintainer:
 Bruno Haible




reply via email to

[Prev in Thread] Current Thread [Next in Thread]