Re: [PATCH] New fallocate module

[Pádraig Brady]

Pádraig Brady wrote:
> Bruno Haible wrote:
>> 
>> The return value convention described in
>>   http://www.kernel.org/doc/man-pages/online/pages/man2/fallocate.2.html
>> is a different one. Either this code or that man page is wrong.
> 
> I don't follow. Both return int. ENOSYS to me means it can't be done
> because part of the stack doesn't support it. The filesystem is the part
> documented as that will be the normal case going forward.
> 
> It's interesting to note, the man page you referenced describes the glibc
> interface as I would expect it. I.E. no <linux/falloc.h> is required
> for the FALLOC_FL_KEEP_SIZE define. I just updated my Fedora 11 system
> to the latest glibc-2.10 and it still requires <linux/falloc.h>

Doh, I see what you mean now.
The man page above says fallocate() returns -1 on error
and sets errno. This is what I would expect TBH, but _not_
what the current fallocate() in glibc-2.10 does.
The current glibc support for this really is all over the place,
so I'll wait until it's fixed before sending the next version.

Thanks for all you help so far.
I'm getting a handle on gnulib stuff now.

cheers,
Pádraig.