[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
hash and bitrotate (was: hash resizing bug)
From: |
Eric Blake |
Subject: |
hash and bitrotate (was: hash resizing bug) |
Date: |
Thu, 18 Jun 2009 13:06:02 -0600 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.21) Gecko/20090302 Thunderbird/2.0.0.21 Mnenhy/0.7.6.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Eric Blake on 6/18/2009 1:00 PM:
>> Then we can use this:
>
>> val = rotr<something> (val, 3);
>
> For rotr64, it is probably superfluous; but for sizes smaller than int
> smaller sizes it makes a difference. I think that warrants a separate
> patch, since it also changes the dependencies for hash.c, as well as
> touching the bitrotate module. But it does sound like a nice idea.
I missed some context there. What I meant was that the '& nnn_MAX' is
superfluous for uint64_t in bitrotate.h. But the use of rotr<something>
in hash.c is a good idea.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAko6kBoACgkQ84KuGfSFAYABDgCfdsLIxQmZ1r1ZxKfRqZGFDRBP
Y/AAnRbKpwPvdjASej+KqV38gm9m4pdP
=a7lG
-----END PGP SIGNATURE-----
- Re: hash resizing bug, (continued)
- Re: hash resizing bug, Jim Meyering, 2009/06/17
- Re: hash resizing bug, Eric Blake, 2009/06/18
- Re: hash resizing bug, Jim Meyering, 2009/06/18
- Re: hash resizing bug, Jim Meyering, 2009/06/18
- Re: hash resizing bug, Jim Meyering, 2009/06/18
- Re: hash resizing bug, Eric Blake, 2009/06/18
- Re: hash resizing bug, Jim Meyering, 2009/06/18
- Re: hash resizing bug, Eric Blake, 2009/06/18
- hash and bitrotate (was: hash resizing bug),
Eric Blake <=
- Re: hash and bitrotate, Eric Blake, 2009/06/18
- Re: hash and bitrotate, Jim Meyering, 2009/06/18
- Re: hash and bitrotate, Simon Josefsson, 2009/06/18
- Re: hash resizing bug, Jim Meyering, 2009/06/18
- Re: hash resizing bug, Ben Pfaff, 2009/06/18
- another hash cleanup (was: hash resizing bug), Eric Blake, 2009/06/18
- Re: another hash cleanup, Jim Meyering, 2009/06/18
- Re: another hash cleanup, Eric Blake, 2009/06/18
- Re: another hash cleanup, Jim Meyering, 2009/06/18
- Re: another hash cleanup, Eric Blake, 2009/06/18