Re: New module argp-version-etc

[Bruno Haible]

Sergey Poznyakoff wrote:
> I have fixed the issues Bruno pointed out in his posting, and committed
> the following changes.

Thanks. The doc is fine: Putting general comments at the top of the file
is a good solution.

> +   If NAME is NULL, the package name (as given by the PACKAGE macro)
> +   is asumed to be the name of the program.
         ^
typo:    assumed

> +Depends-on:
> +argp

A dependency to 'version-etc' is missing. It leads to this error:

$ ./gnulib-tool --test argp-version-etc
...
gcc -DHAVE_CONFIG_H -I. -I../../gllib -I..     -g -O2 -MT argp-version-etc.o 
-MD -MP -MF .deps/argp-version-etc.Tpo -c -o argp-version-etc.o 
../../gllib/argp-version-etc.c
../../gllib/argp-version-etc.c:18:25: error: version-etc.h: No such file or 
directory

Also, there is one warning about 'const':

$ ./gnulib-tool --test --with-tests argp-version-etc version-etc
...
gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../../gllib -I..     -g -O2 -MT 
argp-version-etc.o -MD -MP -MF .deps/argp-version-etc.Tpo -c -o 
argp-version-etc.o ../../gllib/argp-version-etc.c
../../gllib/argp-version-etc.c: In function 'argp_version_setup':
../../gllib/argp-version-etc.c:37: warning: assignment discards qualifiers from 
pointer target type

Bruno