Re: [PATCH] selinux-at: new module

[Jim Meyering]

Bruno Haible wrote:

> Hi Jim,
>
>> +int  getfileconat (int fd, char const *file, security_context_t *con);
>> +int lgetfileconat (int fd, char const *file, security_context_t *con);
>> +int  setfileconat (int fd, char const *file, security_context_t con);
>> +int lsetfileconat (int fd, char const *file, security_context_t con);
>
> These functions have no specification, neither in the .h file nor in the .c
> file. A specification is probably easy to make up, by reference to getfilecon
> and setfilecon (for which gnulib also lacks documentation, btw, see [1] and
> [2]).
>
>> +gl_save_LIBS=$LIBS
>> +  LIB_SELINUX=
>> +  AC_SEARCH_LIBS([setfilecon], [selinux],
>> +                 [test "$ac_cv_search_setfilecon" = "none required" ||
>> +                  LIB_SELINUX=$ac_cv_search_setfilecon])
>> +  AC_SUBST(LIB_SELINUX)

Bad quoting, too!

>> +LIBS=$gl_save_LIBS
>
> These lines is not necessary; LIB_SELINUX is already set by
> m4/selinux-selinux-h.m4, which is part of the 'selinux-h' module,
> on which 'selinux-at' depends.
>
>> +Include:
>> +selinux-at.h
>
> The filename here should be enclosed in double-quotes or angle brackets,
> otherwise "gnulib-tool --extract-include-directive selinux-at" and
> MODULES.html.sh produce an unusable output.
>
> Bruno
>
>
> [1] http://lists.gnu.org/archive/html/bug-gnulib/2008-10/msg00399.html
> [2] http://lists.gnu.org/archive/html/bug-gnulib/2008-10/msg00400.html

Thanks for the feedback!  I will fix these things tomorrow.