[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: close_used_without_requesting_gnulib_module_close
From: |
Bruno Haible |
Subject: |
Re: close_used_without_requesting_gnulib_module_close |
Date: |
Tue, 11 Aug 2009 12:56:27 +0200 |
User-agent: |
KMail/1.9.9 |
With this fix in place, the previous fix from 2009-07-19 [1] is not needed
any more. Only tests that open sockets need to depend on 'close'. I'm applying
this:
[1] http://lists.gnu.org/archive/html/bug-gnulib/2009-07/msg00054.html
2009-08-11 Bruno Haible <address@hidden>
* modules/dup2-tests (Depends-on): Remove close.
Undo 2009-07-19 commit.
* modules/acl-tests (Depends-on): Remove close.
* modules/binary-io-tests (Depends-on): Likewise.
* modules/closein-tests (Depends-on): Likewise.
* modules/flock-tests (Depends-on): Likewise.
* modules/fsync-tests (Depends-on): Likewise.
* modules/lseek-tests (Depends-on): Likewise.
* modules/pipe-tests (Depends-on): Likewise.
* modules/posix_spawn-tests (Depends-on): Likewise.
* modules/posix_spawnp-tests (Depends-on): Likewise.
* modules/stat-time-tests (Depends-on): Likewise.
* modules/yesno-tests (Depends-on): Likewise.
*** modules/acl-tests.orig 2009-08-11 12:48:40.000000000 +0200
--- modules/acl-tests 2009-08-11 08:05:23.000000000 +0200
***************
*** 12,18 ****
read-file
unistd
xalloc
- close
configure.ac:
AC_CHECK_DECLS_ONCE([alarm])
--- 12,17 ----
*** modules/binary-io-tests.orig 2009-08-11 12:48:40.000000000 +0200
--- modules/binary-io-tests 2009-08-11 08:05:23.000000000 +0200
***************
*** 3,9 ****
tests/test-binary-io.c
Depends-on:
- close
configure.ac:
--- 3,8 ----
*** modules/closein-tests.orig 2009-08-11 12:48:40.000000000 +0200
--- modules/closein-tests 2009-08-11 08:05:23.000000000 +0200
***************
*** 4,10 ****
Depends-on:
binary-io
- close
configure.ac:
--- 4,9 ----
*** modules/dup2-tests.orig 2009-08-11 12:48:40.000000000 +0200
--- modules/dup2-tests 2009-08-11 08:19:28.000000000 +0200
***************
*** 2,8 ****
tests/test-dup2.c
Depends-on:
- close
open
configure.ac:
--- 2,7 ----
*** modules/flock-tests.orig 2009-08-11 12:48:40.000000000 +0200
--- modules/flock-tests 2009-08-11 08:05:23.000000000 +0200
***************
*** 3,9 ****
Depends-on:
unistd
- close
configure.ac:
--- 3,8 ----
*** modules/fsync-tests.orig 2009-08-11 12:48:40.000000000 +0200
--- modules/fsync-tests 2009-08-11 08:05:23.000000000 +0200
***************
*** 2,8 ****
tests/test-fsync.c
Depends-on:
- close
configure.ac:
--- 2,7 ----
*** modules/lseek-tests.orig 2009-08-11 12:48:40.000000000 +0200
--- modules/lseek-tests 2009-08-11 08:05:23.000000000 +0200
***************
*** 3,9 ****
tests/test-lseek.sh
Depends-on:
- close
configure.ac:
--- 3,8 ----
*** modules/pipe-tests.orig 2009-08-11 12:48:40.000000000 +0200
--- modules/pipe-tests 2009-08-11 08:05:23.000000000 +0200
***************
*** 4,10 ****
Depends-on:
progname
- close
configure.ac:
--- 4,9 ----
*** modules/posix_spawn-tests.orig 2009-08-11 12:48:40.000000000 +0200
--- modules/posix_spawn-tests 2009-08-11 08:05:23.000000000 +0200
***************
*** 8,14 ****
stdbool
unistd
sys_wait
- close
configure.ac:
AC_EGREP_CPP([notposix], [[
--- 8,13 ----
*** modules/posix_spawnp-tests.orig 2009-08-11 12:48:40.000000000 +0200
--- modules/posix_spawnp-tests 2009-08-11 08:05:23.000000000 +0200
***************
*** 18,24 ****
stdbool
unistd
sys_wait
- close
configure.ac:
AC_EGREP_CPP([notposix], [[
--- 18,23 ----
*** modules/stat-time-tests.orig 2009-08-11 12:48:41.000000000 +0200
--- modules/stat-time-tests 2009-08-11 08:05:23.000000000 +0200
***************
*** 4,10 ****
Depends-on:
time
sleep
- close
configure.ac:
--- 4,9 ----
*** modules/yesno-tests.orig 2009-08-11 12:48:41.000000000 +0200
--- modules/yesno-tests 2009-08-11 08:05:23.000000000 +0200
***************
*** 5,11 ****
Depends-on:
closein
binary-io
- close
configure.ac:
--- 5,10 ----