[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Use $(MKDIR_P) instead of @MKDIR_P@
From: |
Jim Meyering |
Subject: |
Re: Use $(MKDIR_P) instead of @MKDIR_P@ |
Date: |
Mon, 31 Aug 2009 18:13:40 +0200 |
Simon Josefsson wrote:
> Getting gnulib to build natively on Windows was a bit difficult, "make"
> appears to break when trying to CreateProcess on /usr/bin/mkdir which
> doesn't exist as a binary. How about this patch? It allows users to
> specify the mkdir command when invoking 'make'.
>
> The patch seems generally to be the Right Thing, but maybe there are
> other ways to handle the missing mkdir issue on Windows?
>
> /Simon
>
> diff --git a/modules/arpa_inet b/modules/arpa_inet
> index 55aa68f..cee421b 100644
> --- a/modules/arpa_inet
> +++ b/modules/arpa_inet
> @@ -20,7 +20,7 @@ BUILT_SOURCES += $(ARPA_INET_H)
> # We need the following in order to create <arpa/inet.h> when the system
> # doesn't have one.
> arpa/inet.h: arpa_inet.in.h
> - $(AM_V_at)@MKDIR_P@ arpa
> + $(AM_V_at)$(MKDIR_P) arpa
That looks good to me (though note that none of those are mine).
I've been lobbying to remove the obsolescent @VAR@ notation
in favor of $(VAR) notation for a long time.