Re: mingw test cleanups

[Jim Meyering]

Eric Blake wrote:
> I will be pushing these later today as prerequisites to fixing fchdir and
> splitting fdopendir into its own module.  This series avoids some compilation
> warnings due to missing chmod on mingw, and allows me to run gnulib testsuites
> under cygwin while cross-compiling to mingw:
...
> From: Eric Blake <address@hidden>
> Date: Mon, 31 Aug 2009 09:00:45 -0600
> Subject: [PATCH 1/2] chown: avoid compilation warning on mingw
>
> * m4/chown.m4 (gl_FUNC_CHOWN): Recognize missing chown.
> * lib/chown.c (rpl_chown) [!HAVE_CHOWN]: Always return failure on
> mingw.
> * lib/lchown.c (lchown) [!HAVE_CHOWN]: Likewise.
> * modules/chown (Depends-on): Add errno.
...

The above looks fine.
However, there are two missing "$" signs below:

>>From b5303b066289f6d618c349def738f4b688dc1349 Mon Sep 17 00:00:00 2001
> From: Eric Blake <address@hidden>
> Date: Mon, 31 Aug 2009 09:12:30 -0600
> Subject: [PATCH 2/2] canonicalize: allow cross-testing from cygwin to mingw
>
> * modules/canonicalize-tests (configure.ac): Define HAVE_SYMLINK.
> (Makefile.am): Pass it through TESTS_ENVIRONMENT.
> * modules/canonicalize-lgpl-tests (configure.ac, Makefile.am):
> Likewise.
> * tests/test-canonicalize.sh: Also skip test if 'ln -s' works, but
> target does not support symlinks.
> * tests/test-canonicalize-lgpl.sh: Likewise.
...
> diff --git a/modules/canonicalize-lgpl-tests b/modules/canonicalize-lgpl-tests
> index 5028ee7..9d86078 100644
> --- a/modules/canonicalize-lgpl-tests
> +++ b/modules/canonicalize-lgpl-tests
> @@ -5,9 +5,12 @@ tests/test-canonicalize-lgpl.c
>  Depends-on:
>
>  configure.ac:
> +AC_CHECK_FUNCS_ONCE([symlink])
> +HAVE_SYMLINK=ac_cv_func_symlink

HAVE_SYMLINK=$ac_cv_func_symlink

> +AC_SUBST([HAVE_SYMLINK])
>
>  Makefile.am:
>  TESTS += test-canonicalize-lgpl.sh
> -TESTS_ENVIRONMENT += EXEEXT='@EXEEXT@'
> +TESTS_ENVIRONMENT += EXEEXT='@EXEEXT@' HAVE_SYMLINK='$(HAVE_SYMLINK)'
>  check_PROGRAMS += test-canonicalize-lgpl
>  test_canonicalize_lgpl_LDADD = $(LDADD)
> diff --git a/modules/canonicalize-tests b/modules/canonicalize-tests
> index 875984e..092b9ef 100644
> --- a/modules/canonicalize-tests
> +++ b/modules/canonicalize-tests
> @@ -5,9 +5,12 @@ tests/test-canonicalize.c
>  Depends-on:
>
>  configure.ac:
> +AC_CHECK_FUNCS_ONCE([symlink])
> +HAVE_SYMLINK=ac_cv_func_symlink

HAVE_SYMLINK=$ac_cv_func_symlink

> +AC_SUBST([HAVE_SYMLINK])
>
>  Makefile.am:
>  TESTS += test-canonicalize.sh
> -TESTS_ENVIRONMENT += EXEEXT='@EXEEXT@'
> +TESTS_ENVIRONMENT += EXEEXT='@EXEEXT@' HAVE_SYMLINK='$(HAVE_SYMLINK)'
>  check_PROGRAMS += test-canonicalize
>  test_canonicalize_LDADD = $(LDADD) @LIBINTL@