bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] syntax-check: detect unnecessary inclusion of openat.h


From: Jim Meyering
Subject: [PATCH] syntax-check: detect unnecessary inclusion of openat.h
Date: Sat, 05 Sep 2009 19:56:49 +0200

With the recent migration of most *at function declarations out of
openat.h, it's worthwhile to ensure that applications do not include
openat.h unless they actually use at least one of the functions
mentioned in the new, pared-down header.

>From 77f13fca7be5bd73eb71c3be54fd752941914356 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sat, 5 Sep 2009 19:54:12 +0200
Subject: [PATCH] syntax-check: detect unnecessary inclusion of openat.h

* top/maint.mk (sc_prohibit_openat_without_use): New rule.
---
 ChangeLog    |    5 +++++
 top/maint.mk |    5 +++++
 2 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 69c5c16..c53c7f8 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2009-09-05  Jim Meyering  <address@hidden>
+
+       syntax-check: detect unnecessary inclusion of openat.h
+       * top/maint.mk (sc_prohibit_openat_without_use): New rule.
+
 2009-09-05  Bruno Haible  <address@hidden>

        Support towlower, towupper.
diff --git a/top/maint.mk b/top/maint.mk
index 929d8c3..45bc0c9 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -293,6 +293,11 @@ sc_prohibit_root_dev_ino_without_use:
        re='(\<ROOT_DEV_INO_(CHECK|WARN)\>|\<get_root_dev_ino *\()' \
          $(_header_without_use)

+sc_prohibit_openat_without_use:
+       @h='"openat.h"' \
+       
re='\<(openat_(permissive|needs_fchdir|(save|restore)_fail)|l?ch(own|mod)at)\>' 
\
+         $(_header_without_use)
+
 # Prohibit the inclusion of c-ctype.h without an actual use.
 ctype_re = isalnum|isalpha|isascii|isblank|iscntrl|isdigit|isgraph|islower\
 |isprint|ispunct|isspace|isupper|isxdigit|tolower|toupper
--
1.6.4.2.409.g85dc3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]