[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: make openat declarations consistent
From: |
Eric Blake |
Subject: |
Re: make openat declarations consistent |
Date: |
Sun, 06 Sep 2009 14:36:06 -0600 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Bruno Haible on 9/6/2009 2:22 PM:
> Eric Blake wrote:
>> configure.ac:
>> gl_FUNC_OPENAT
>> +gl_MODULE_INDICATOR([openat])
>
> This is not needed for gnulib: There is no use of GNULIB_OPENAT as a C
> preprocessor macro anywhere in lib/, nor in coreutils. So I propose to
> remove this unneeded witness.
Oh, I see - GNULIB_OPENAT is used as a shell variable for substitution in
three .in.h files, but not used as a C macro. So we only need the
AC_SUBST (provided by gl_OPENAT_DEFAULTS), not the AC_DEFINE (provided by
gl_MODULE_INDICATOR). Yes, okay to make that change.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkqkHTYACgkQ84KuGfSFAYDYGACgjgPJU83ifwLOzFceslHu0jgS
9tAAoJtesEW2A9zCiMpTEBs7ejghhWfL
=k4tv
-----END PGP SIGNATURE-----