bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/5] Handle Windows CE and rewrite NT version handling.


From: Bruno Haible
Subject: Re: [PATCH 4/5] Handle Windows CE and rewrite NT version handling.
Date: Fri, 2 Oct 2009 02:38:19 +0200
User-agent: KMail/1.9.9

Paolo Bonzini wrote:
> But you do see the 5/0, 5/1, 5/2, 6/0, 6/1 pairs.  I did it all but to 
> save instructions.  It was more readable for me.

If you want to make a switch statement for pairs, use a macro
  #define PAIR(major,minor) (((major)<<8)|(minor))
and use PAIR(5,2) etc. Then it's clear what you mean.

Note also that the patch moved the 'default' case with Windows NT 3.5 and
4.0 to the end, after Windows Vista - which may also be less readable than
keeping a roughly chronological list.

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]