Re: more warnings patrol

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Bruno Haible on 10/30/2009 6:43 PM:
> Hi Eric,
> 
>> --- a/lib/mktime.c
>> +++ b/lib/mktime.c
>> @@ -147,6 +147,9 @@ const unsigned short int __mon_yday[2][13] =
>>  # undef __localtime_r
>>  # define __localtime_r localtime_r
>>  # define __mktime_internal mktime_internal
>> +time_t __mktime_internal (struct tm *,
>> +                         struct tm * (*) (time_t const *, struct tm *),
>> +                         time_t *);
>>  #endif
>>
>>  /* Return an integer value measuring (YEAR1-YDAY1 HOUR1:MIN1:SEC1) -
> 
> Here gcc was essentially complaining that 'mktime_internal' is not
> declared in a header file. Such a header file would be appropriate,
> to ensure that the declarations in mktime.c and timegm.c don't run
> out of sync.

Agreed, but this is just doing the same thing that timegm.c already did.

> 
> How about moving this declaration to a new file mktime-internal.h?

And share it between the mktime and timegm modules.  Yes, that sounds nice.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkrrikcACgkQ84KuGfSFAYBZDQCgkMG/NgkD5oPRw1MAKGczHd3k
7nwAoIWiXHdr7WdM6zTC3VDb1gZ4Iae7
=eTO5
-----END PGP SIGNATURE-----