Re: Explicit interpreter paths considered harmful

[Simon Josefsson]

Simon Josefsson <address@hidden> writes:

> address@hidden (Ludovic Courtès) writes:
>
>> Hello,
>>
>> Simon Josefsson <address@hidden> writes:
>>
>>> I'm considering simply doing the following, since the recommended way to
>>> invoke the awk script is by 'awk -f SCRIPT'.  Thoughts?
>>
>> Then it’d be nice to clear the executable bit as well.
>
> Sounds fine.  I'll push the patch below shortly.

I followed up with this patch too, which includes my patch mentioned
above.

/Simon

>From 3431a129a1801dad2ca8bac3ca5cf417b6dc9139 Mon Sep 17 00:00:00 2001
From: Simon Josefsson <address@hidden>
Date: Fri, 6 Nov 2009 14:36:24 +0100
Subject: [PATCH 1/2] build-aux/pmccabe2html: Drop #! header.  Doc fix.

---
 ChangeLog              |    1 +
 build-aux/pmccabe2html |   14 ++++++--------
 2 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 655683e..10868e8 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -3,6 +3,7 @@
        * build-aux/pmccabe2html: Disable execute bit.  Suggested by
        Reported by Ludovic Courtès.
        * build-aux/pmccabe2html: Improve example usage.
+       * build-aux/pmccabe2html: Drop #! header.  Doc fix.
 
 2009-11-06  Jim Meyering  <address@hidden>
 
diff --git a/build-aux/pmccabe2html b/build-aux/pmccabe2html
index ea3e262..dd397cf 100644
--- a/build-aux/pmccabe2html
+++ b/build-aux/pmccabe2html
@@ -1,6 +1,4 @@
-#!/bin/sh
-exec awk -f "$0" "$@"
-# pmccabe2html - pmccabe to html converter
+# pmccabe2html - AWK script to convert pmccabe output to html
 
 # Copyright (C) 2007, 2008, 2009 Free Software Foundation, Inc.
 
@@ -23,16 +21,16 @@ exec awk -f "$0" "$@"
 
 # Typical Invocation is from a Makefile.am:
 #
-# cyclo-$(PROJECT).html:
+# cyclo-$(PACKAGE).html:
 #      $(PMCCABE) ${top_srcdir}/lib/*.[ch] \
 #              | sort -nr \
 #              | $(AWK) -f ${top_srcdir}/build-aux/pmccabe2html \
 #                      -v lang=html -v name="$(PACKAGE_NAME)" \
-#                      -v 
vcurl="http://git.savannah.gnu.org/gitweb/?p=$(PROJECT).git;a=blob;f=%FILENAME%;hb=HEAD"
 \
-#                      -v url="http://www.gnu.org/software/$(PROJECT)/" \
+#                      -v 
vcurl="http://git.savannah.gnu.org/gitweb/?p=$(PACKAGE).git;a=blob;f=%FILENAME%;hb=HEAD"
 \
+#                      -v url="http://www.gnu.org/software/$(PACKAGE)/" \
 #                       -v css=${top_srcdir}/build-aux/pmccabe.css \
-#                      > tmp
-#      mv tmp $@
+#                      > address@hidden
+#      mv address@hidden $@
 #
 # The variables available are:
 #   lang     output language, either 'html' or 'wiki'
-- 
1.6.5.2