bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 4 test failures on freebsd8-rc2


From: Jim Meyering
Subject: Re: 4 test failures on freebsd8-rc2
Date: Thu, 12 Nov 2009 07:51:16 +0100

Eric Blake wrote:

> According to Eric Blake on 11/10/2009 6:51 AM:
>> rm a
>> mkfifo b/         => mistakenly creates a
>>
>> So I've got a few more to go.  For that matter, Solaris 9 has the same
>> bugs for chmod and chown, but we don't have a chmod replacement yet.
>
> Here's what I'm applying for mkfifo/mknod; tested across OpenBSD, FreeBSD,
> Solaris 9 and 10, Linux, and cygwin.

Nice.  Thanks!

> chown will be harder, since there is no test-chown already written to
> start from.  I'm starting to think I will have to use getgroups to see
> whether the current user has a supplementary group membership, since
> that's about the only observable successful change that can be made to
> pinpoint whether the right file was modified.  But that means the test
> will be reduced, or even skipped, if the user only belongs to one group.

I think that would be fine.  AFAIK, there is no alternative.
This is already the case for several of coreutils' tests.
They're skipped when require_membership_in_two_groups_
(from tests/test-lib.sh) fails.

For this reason, when possible on test systems, I give myself
membership in a second group.

> And then there's mingw to worry about, with neither getgroups nor chown.
> Also, the gnulib implementation of getgroups can call exit(), so I'd like
> to fix that first.

coreutils' mgetgroups does that.
I guess it's time to move that module into gnulib.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]