bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fts: do not fail on a submount during traversal


From: Jim Meyering
Subject: Re: [PATCH] fts: do not fail on a submount during traversal
Date: Thu, 12 Nov 2009 12:44:48 +0100

Kamil Dudka wrote:
> we've discussed with Jim the issue with mounts triggered during directory
> tree traversal and we've decided to make a trade-off for now - enable the
> extra stat call only if the FTS_TIGHT_CYCLE_CHECK is set. This means it only
> affects find and du for now and leaves other utilities to work as they used
> to work before (failing on the triggered mount). I think this is a good
> enough temporary solution since we are still waiting for reply from the
> kernel guys.
...
> Subject: [PATCH] fts: do not fail on a submount during traversal
>
> * lib/fts.c (fts_build): Read the stat info again after opening
> a directory if the FTS_TIGHT_CYCLE_CHECK flag is set.
> Original report at http://bugzilla.redhat.com/501848.

Hi Kamil,

Thanks for the patch.
I've applied and pushed that.
I adjusted the comment, since I view this addition not as a feature,
but rather as a kludge to work around brokenness in the NFS4 implementation.
Even though it affects only du and find now, the fact that everyone
incurs a performance penalty for the work-around is irksome.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]