[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] pread: new module
From: |
Eric Blake |
Subject: |
Re: [PATCH 1/2] pread: new module |
Date: |
Wed, 25 Nov 2009 16:43:03 +0000 (UTC) |
User-agent: |
Loom/3.14 (http://gmane.org/) |
Jim Meyering <jim <at> meyering.net> writes:
> + off_t old_offset = __libc_lseek (fd, 0, SEEK_CUR);
> +Depends-on:
> +unistd
> +
Needs to depend on lseek, particularly since pread is replaced on mingw, and
mingw has an lseek bug with non-seekable files (like pipes).
Perhaps test-pread.sh should also check that pread fails with ESPIPE on a non-
seekable fd? Also, the test should probably cover EINVAL for trying to read
negative offsets.
--
Eric Blake
- [PATCH 1/2] pread: new module, Jim Meyering, 2009/11/25
- Re: [PATCH 1/2] pread: new module, Richard W.M. Jones, 2009/11/25
- Re: [PATCH 1/2] pread: new module,
Eric Blake <=
- Re: [PATCH 1/2] pread: new module, Jim Meyering, 2009/11/25
- Re: [PATCH 1/2] pread: new module, Jim Meyering, 2009/11/25
- Re: [PATCH 1/2] pread: new module, Jim Meyering, 2009/11/25
- Re: [PATCH 1/2] pread: new module, Bruno Haible, 2009/11/25
- Re: [PATCH 1/2] pread: new module, Eric Blake, 2009/11/26
- Re: [PATCH 1/2] pread: new module, Jim Meyering, 2009/11/26
- Re: [PATCH 1/2] pread: new module, Bruno Haible, 2009/11/26
- Re: [PATCH 1/2] pread: new module, Jim Meyering, 2009/11/26