[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests/init.sh: new file to be used via most *.sh tests
From: |
Jim Meyering |
Subject: |
Re: [PATCH] tests/init.sh: new file to be used via most *.sh tests |
Date: |
Thu, 26 Nov 2009 11:19:00 +0100 |
Bruno Haible wrote:
> Jim Meyering wrote:
>> --- a/tests/init.sh
>> +++ b/tests/init.sh
>> @@ -27,6 +27,7 @@
>> # Note that these commands are executed in a subdirectory, therefore you
>> # need to prepend "../" to relative filenames in the build directory.
>> # Set the exit code 0 for success, 77 for skipped, or 1 or other for
>> failure.
>> +# Use the skip_ and fail_ functions to print a diagnostic and then exit
>
> What is the meaning of the trailing underscore convention? I guessed that
> functions with a trailing underscore were internal and the capitalized names
> were exported from the script. Would it not make sense to rename skip_ and
> fail_ then, if they are user-visible?
My goal was to keep the symbols from init.sh
from impinging on the test-writer's name space.
Re: [PATCH] tests/init.sh: new file to be used via most *.sh tests, Jim Meyering, 2009/11/26
Re: [PATCH] tests/init.sh: new file to be used via most *.sh tests, Ralf Wildenhues, 2009/11/27