[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] bootstrap: handle perl-5.11's changed --version output
From: |
Jim Meyering |
Subject: |
Re: [PATCH] bootstrap: handle perl-5.11's changed --version output |
Date: |
Mon, 30 Nov 2009 13:51:03 +0100 |
Pádraig Brady wrote:
> Jim Meyering wrote:
>> with F12's 5.10.0, I see this:
>>
>> $ perl -le 'print $]'
>> 5.010000
>
> I didn't use $] in the adjusted get_version() I sent :)
>
>> So $^V appears to be out.
>>
>> Want to write the patch?
>> There must be something canonical and "easy" in Perl itself, considering
>> the prevalence of the desired version string, e.g. in perl's own search path.
>
> Well I couldn't see any and just resorted to parsing
> `perl --version` as before. So the attached patch just
> uses the get_version() I previously sent in this thread
> (which also handles the output from 5.11.2-81...)
That works for me.
I pretended that 5.11.3 was the minimum and got the desired diagnostic:
Error: 'perl' version == 5.11.2-81-g162177c is too old
'perl' version >= 5.11.3 is required
Likewise when using 5.10.0 and with 5.10.1 listed as the minimum:
Error: 'perl' version == 5.10.0 is too old
'perl' version >= 5.10.1 is required
So I've pushed it.
Thanks!
> Subject: [PATCH] bootstrap: fix handling of various perl --version formats
>
> * build-aux/bootstrap (get_version): Don't use perl's $] special
> variable, as that requires updating all bootstrap.conf files to
> use perl's x.yyyzzz version format. Instead make the regular
> expression more general to support version formats from older
> perl-5.005_002 (5.5.2) and perl-5.11 which has other numbers
> in the version line.