bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: announce-gen -- not flexible enough


From: Jim Meyering
Subject: Re: announce-gen -- not flexible enough
Date: Sat, 05 Dec 2009 18:41:49 +0100

Alfred M. Szmidt wrote:
>    You said you would not be changing announce-gen, so isn't it moot?
>
> I said that I did not have enough knowledge to hack announce-gen since
> it is written in perl; I cannot do something when I don't know how to
> do it.
>
>    I pointed out that yet another script parses (and rewrites) NEWS
>    and would need similar changes.
>
> Right, so something similar needs to be added there.  I can do it for
> do-release-commit-and-tag, since that is in shell script.  Attached is
> a quick hack, that I didn't bother testing.

Good start.
Please use git format-patch output...
and name the variable "require_news"

I.e., initialize "require_news=true"
or to false, then run the "command":

    if $require_news; then
      ...
    fi

By reversing the sense of the name, you make it so the three
added tests are not all negated.  That's more readable.

> Is there is someone who can add a --skip-news option to announce-gen,
> (and a way of specifying that you don't want NEWS to be inserted in
> cfg.mk; though I can do that)?  If not, the best solution is to remove
> announce-gen from gnulib, since it is not flexible enough for other
> projets to use; asking everyone to use the same format for a file that
> has been free-hand for 20+ years is not going to work.

Removing something just because it doesn't suit *you* would be
unreasonable.  What about all of the other projects that are using it?

No one is forcing you to use any particular part of gnulib.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]