[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: fchdir fixes
From: |
Jim Meyering |
Subject: |
Re: fchdir fixes |
Date: |
Tue, 08 Dec 2009 15:51:26 +0100 |
Eric Blake wrote:
> fchdir is working on mingw, which is about the only modern portability
> target that lacks fchdir, but it is sure easier to test on other platforms
> than mingw. So before making rpl_fcntl (and having it call
> _gl_register_dup at the right places), I decided to try './configure
> ac_cv_func_fchdir=no' on a system with fchdir. That failed miserably, so
> I'm pushing the following.
...
> Subject: [PATCH 2/2] fchdir: fix logic bugs
...
> diff --git a/m4/fchdir.m4 b/m4/fchdir.m4
> -]], [return open(".", O_RDONLY);])],
> +]], [return open(".", O_RDONLY) < 0;])],
Good catch.
The rest looks fine, too.