bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] non-null declarations


From: Paolo Bonzini
Subject: Re: [PATCH] non-null declarations
Date: Thu, 10 Dec 2009 20:01:27 +0100

On Thu, Dec 10, 2009 at 19:41, Bruno Haible <address@hidden> wrote:
> Paolo Bonzini wrote:
>> accept4 has to be fixed to use ((2, 3)). :-)
>
> No, the second arg of accept4 can be NULL. See
>  <http://www.kernel.org/doc/man-pages/online/pages/man2/accept4.2.html>
>  "When addr is NULL, nothing is filled in; in this case, addrlen is not used,
>   and should also be NULL."
> I have to remove the annotations for accept() and accept4().

Good!

>> > OpenGL macro names start with GL_. So if we choose the prefix _GL_ we're
>> > not likely to collide.
>>
>> What about internal OpenGL macro names?
>
> They start with GL or __GL. Not with _GL.

Still sounds pretty brittle... GNULIB_ or _GNULIB_ doesn't sound so
bad, but I don't care as renaming can be done later anyway.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]