[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] binary-io: always define SET_BINARY as an expression
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH] binary-io: always define SET_BINARY as an expression |
|
Date: |
Thu, 24 Dec 2009 13:06:56 -0700 |
|
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Ben Pfaff on 12/24/2009 12:00 PM:
> Jim Meyering <address@hidden> writes:
>
>> -# define SET_BINARY(fd) /* nothing */
>> +# define SET_BINARY(fd) 0
>
> For me, with -Wall, plain 0 as a statement provokes a warning
> "statement with no effect", but writing (void) 0 suppresses that
> warning.
Which implies the need for:
# define SET_BINARY(fd) ((void) 0)
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkszyeAACgkQ84KuGfSFAYC7jgCfT5oceK73k0/dDRQja7miQvGl
QiwAoIGudiCafmgRSL3V/AlW95LfXYbV
=k0RW
-----END PGP SIGNATURE-----