test-symlink failure on MinGW

[Simon Josefsson]

I got this error when cross-compiling to MinGW:

../../../src/libidn-1.16/gltests/test-symlink.c:43: assertion failed
FAIL: test-symlink.exe

The reason is use of a system call.  I changed it into a shell script
wrapper instead.  OK to push?

/Simon

>From d2d668d5315e9b43bba02fbcf385e7bc2771b1e5 Mon Sep 17 00:00:00 2001
From: Simon Josefsson <address@hidden>
Date: Sun, 27 Dec 2009 11:05:50 +0100
Subject: [PATCH] test-symlink: Don't use system.

---
 ChangeLog             |    7 +++++++
 modules/symlink-tests |    4 +++-
 tests/test-symlink.c  |    3 ---
 tests/test-symlink.sh |    6 ++++++
 4 files changed, 16 insertions(+), 4 deletions(-)
 create mode 100755 tests/test-symlink.sh

diff --git a/ChangeLog b/ChangeLog
index 5e309e6..22cfa71 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2009-12-27  Simon Josefsson  <address@hidden>
+
+       * tests/test-symlink.c (main): Don't use system here, doesn't work
+       with cross-compiled MinGW.
+       * tests/test-symlink.sh: New file.
+       * modules/symlink-tests (Files): Add it.
+
 2009-12-26  Bruno Haible  <address@hidden>
 
        Remove an unneeded dependency.
diff --git a/modules/symlink-tests b/modules/symlink-tests
index 3f94fd2..f15a611 100644
--- a/modules/symlink-tests
+++ b/modules/symlink-tests
@@ -1,6 +1,7 @@
 Files:
 tests/test-symlink.h
 tests/test-symlink.c
+tests/test-symlink.sh
 tests/signature.h
 tests/macros.h
 
@@ -10,5 +11,6 @@ stdbool
 configure.ac:
 
 Makefile.am:
-TESTS += test-symlink
+TESTS += test-symlink.sh
+TESTS_ENVIRONMENT += EXEEXT='@EXEEXT@'
 check_PROGRAMS += test-symlink
diff --git a/tests/test-symlink.c b/tests/test-symlink.c
index c84b2bc..3247449 100644
--- a/tests/test-symlink.c
+++ b/tests/test-symlink.c
@@ -39,8 +39,5 @@ SIGNATURE_CHECK (symlink, int, (char const *, char const *));
 int
 main (void)
 {
-  /* Remove any leftovers from a previous partial run.  */
-  ASSERT (system ("rm -rf " BASE "*") == 0);
-
   return test_symlink (symlink, true);
 }
diff --git a/tests/test-symlink.sh b/tests/test-symlink.sh
new file mode 100755
index 0000000..8fa15b5
--- /dev/null
+++ b/tests/test-symlink.sh
@@ -0,0 +1,6 @@
+#!/bin/sh
+
+# Remove any leftovers from a previous partial run.
+rm -rf test-symlink.t*
+
+exec ./test-symlink${EXEEXT}
-- 
1.6.5.7